Use Send-MailMessage instead of SmtpClient / General Cleanup

lazywinadmin / Monitor-ADGroupMembership

PowerShell script to monitor Active Directory groups and send an email when someone is changing the membership

MIT License

264 stars 61 forks source link

Use Send-MailMessage instead of SmtpClient / General Cleanup #44

Closed JaimeStill closed 5 years ago

JaimeStill commented 5 years ago

Per issue #43 , Send-MailMessage is used instead of SmtpClient to enable sending emails through Office 365.

Other changes include:

The addition of an EmailPort parameter to provide to Send-MailMessage
Get-Credential is called at the top of the Begin region so that credentials can be passed to Send-MailMessage
General cleanup and formatting of the overall script (only dealing with fixing style inconsistencies, not changing actual functionality)

lazywinadmin commented 5 years ago

Thanks @JaimeStill ! Appreciated!

Other than the Email Edit, I see a lot of changes. If you submit another PR please keep the changes focus on one particular aspect, easier to review :sweat_smile:

I agree with most of your changes except for:

All the semi-colon which are not necessary in PowerShell (looks like you have a developer background c# ? :smile: )
Way you handle credentials, it should not prompt if the user use the current account.
Date format of the report, I should actually update it to use something like get-date -format o which includes the timezone.

JaimeStill commented 5 years ago

No worries! Apologies for how chaotic the commit was, I'd just pushed up the whole revision I'd made not thinking you may want a PR for it.

Definitely more acquainted with C# / full stack dev than PowerShell, but it's something I enjoy and find fascinating. I've done some really cool stuff building web apps centered around calling PS stuff via Web API. If you'd be interested in anything like that, feel free to shoot me an email (on my profile)!