learn-awesome / learn

A social network of lifelong learners built around humanity's universal learning map.
https://learnawesome.org/
Other
345 stars 40 forks source link

Life-Slider Styling and localStorage #250

Closed JosephMcGreene closed 3 years ago

JosephMcGreene commented 3 years ago

I updated the age indicator with some styling, but am unable to add a ping animation as of now. However, the range input's value and therefore the user's age, are now stored in the user's localStorage.

nileshtrivedi commented 3 years ago

Hi @JosephMcGreene

Thanks for this PR. Can you please rebase with master so that there are no conflicts? I will then merge it.

BTW, it would have been nicer if you had submitted the formatting changes in a separate PR. This is essential for reviewing exactly what code you have changed. For now, I had to go through each of your commits individually.

nileshtrivedi commented 3 years ago

I incorporated your changes as well as added the "Do Good" section and then merged/deplopyed it. Closing this.