Resolve issue #267 - Githubissues

learnables / learn2learn

A PyTorch Library for Meta-learning Research

http://learn2learn.net

MIT License

2.62k stars 350 forks source link

Resolve issue #267 #283

Closed nightlessbaron closed 2 years ago

nightlessbaron commented 2 years ago

Description

Fixes #267

As discussed with @seba-1511, adds an option for RGB bands for Random Rotation.

Contribution Checklist

If your contribution modifies code in the core library (not docs, tests, or examples), please fill the following checklist.

[x] My contribution is listed in CHANGELOG.md with attribution.
[x] My contribution modifies code in the main library.
[x] My modifications are tested.
[ ] My modifications are documented.

nightlessbaron commented 2 years ago

One more thing that can be added is a try-catch for the older version of torchvision. It seems that the tests are failing for the same reason. Let me know if I should add it @seba-1511

seba-1511 commented 2 years ago

Thanks for this PR @nightlessbaron!

Yes, catching the exception for older versions is a good idea. Some more comments from a quick glance at the code:

I think you can remove Compose around the random rotation (but you'll need it for older versions when converting to and from PIL).
The tests you included already look great. Could we also have a few small unit tests that don't require a dataset (you can pass a 4-dim random tensor instead of real images)?

Let me know when it's ready for a full review, and thanks again.

nightlessbaron commented 2 years ago

@seba-1511, thanks for your review. I have incorporated the changes you suggested. Can you have a final check again? Thank you!

seba-1511 commented 2 years ago

@nightlessbaron, this looks great and looks ready to merge -- thanks for persisting! Do you want to add a line to CHANGELOG.md and credit yourself?

nightlessbaron commented 2 years ago

Thanks, @seba-1511, it's done.