data_augmentation for get_tasks

learnables / learn2learn

A PyTorch Library for Meta-learning Research

http://learn2learn.net

MIT License

2.62k stars 350 forks source link

data_augmentation for get_tasks #306

Closed brando90 closed 2 years ago

brando90 commented 2 years ago

Description

adding data_augmentation to get_tasksets

Contribution Checklist

If your contribution modifies code in the core library (not docs, tests, or examples), please fill the following checklist.

[ ] My contribution is listed in CHANGELOG.md with attribution.
[x] My contribution modifies code in the main library.
[ ] My modifications are tested.
[ ] My modifications are documented.

seba-1511 commented 2 years ago

Hi @brando90 and thanks for this PR,

Unfortunately I think this change goes against the the design principle that get_tasksets should reproduce benchmarks from the literature. My recommendation is to include the augmentations in the benchmarks themselves (like you already did in #303 and #305 -- thanks for that!).