search

learnables / learn2learn

A PyTorch Library for Meta-learning Research
http://learn2learn.net
MIT License
2.62k stars 350 forks source link

Typo/minor issue in clone_module function #329

Closed KrikunovEV closed 2 years ago

KrikunovEV commented 2 years ago

Hi everyone! Probably I found a minor issue, just a typo. I don't think it breaks anything.

In the following row, there should be memo[buff_ptr] = cloned, isn't it? https://github.com/learnables/learn2learn/blob/36ac4fb8f91fec291becb4757720a82c72c550b8/learn2learn/utils/__init__.py#L139

seba-1511 commented 2 years ago

Hi @KrikunovEV ,

Thanks for sorting this, I think you’re right. Do you want to submit a PR to fix it?

KrikunovEV commented 2 years ago

Thanks, @seba-1511 Yes, I will try!