Fixes broken drive download functionality using gdown, and ensures data is properly unzipped - Githubissues

learnables / learn2learn

A PyTorch Library for Meta-learning Research

http://learn2learn.net

MIT License

2.59k stars 348 forks source link

Fixes broken drive download functionality using gdown, and ensures data is properly unzipped #398

Closed AntreasAntoniou closed 1 year ago

AntreasAntoniou commented 1 year ago

Description

Fixes broken drive download functionality using gdown, and ensures data is properly unzipped (was getting errors with previous unzipping process).

Ensures datasets are properly downloadable and unzippable.

If necessary, use the following space to provide context or more details.

Contribution Checklist

If your contribution modifies code in the core library (not docs, tests, or examples), please fill the following checklist.

[x] My contribution is listed in CHANGELOG.md with attribution.
[x] My contribution modifies code in the main library.
[x] My modifications are tested.
[x] My modifications are documented.

seba-1511 commented 1 year ago

Hello @AntreasAntoniou,

Thanks for the PR! I took a look yesterday and hopefully #400 solves the download issues so we can avoid adding gdown as an extra dependency.

Regarding unzipping: could you rebase and check if you see the same issue? If so, which platform is it on? I just tested on macOS and Ubuntu and these seem fine (when downloading from Zenodo).