search

leelakrishnan / FlyTV

fly-tv.vercel.app
0 stars 0 forks source link

Improved descriptiveness in readme as per Konstantin #55

Closed tippi-fifestarr closed 2 years ago

tippi-fifestarr commented 2 years ago

Worked on adding DAO concept and some basic descriptiveness to the readme. Next will add descriptive text to the most recent version.

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [2910823](https://dashboard.gitguardian.com/incidents/2910823?occurrence=25408204) | Generic High Entropy Secret | e08484eb3619ead29f30596ffbc60b096ac1c55a | my-app/components/TeamProjectBlobAsNFT.tsx | [View secret](https://github.com/leelakrishnan/FlyTV/commit/e08484eb3619ead29f30596ffbc60b096ac1c55a#diff-6d47ab9c26db0b1af80ab10130ac294b09a08a9d5406389dadb1856557edac20R8) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

tippi-fifestarr commented 2 years ago

Added tons of descriptive texts, and even styled it a bit. added 2 buttons for other hackathons (obviously for the demo we just do faber) and some readme updates.