leezer3 / OpenBVE

OpenBVE- A free train simulator
http://www.openbve-project.net
272 stars 52 forks source link

[Suggestion] Behavioral differences in AnnounceAll and last car #1005

Open JunmoreHeavyBox opened 5 months ago

JunmoreHeavyBox commented 5 months ago

Description

The axle of each car will trigger a sound, and the rear axle of the last car will not be triggered.

Only the front axle of each car triggers a sound, while both axles of the last car trigger a sound.

Out of the meaning of "all (axle)", I would like to exchange features with Announce.

The sound triggered sequentially by the front axle of each car, strangely, both axles of the last car triggered the sound, causing repetition.

This is not the sound event I imagined. What I thinking is for all cars to play simultaneously.

I even think it can be used for pitch fixed joint sounds, but it lacks a rear axle and repeatable triggering.

#

Funny thing, I made a derailment sound event based on the #997 to entertain myself:)

I want to ask about the difference between DopplerAll.

leezer3 commented 5 months ago

Fixed the AnnounceAll rear axle trigger issue, which was unintentional.

Adding a new event type which triggers on all axles would possibly be do-able, although I'm not sure that your joint idea is going to work in a sensible way in terms of performance.

With regards to DopplerAll, I suspect the difference you're seeing is because the train speed is calculated each time the event occurs. If the train speed is changing as each car passes over the event, you'll inevitably get differing pitch values.

JunmoreHeavyBox commented 5 months ago

My idea of rail joints will be discussed in the next issue. I just want to ask about the difference between DopplerAll and the original Doppler, I'm sorry. AnnounceAll did not trigger any sound in this build.

leezer3 commented 5 months ago

Apologies, errant return statement that I thought I'd removed....