search

leezer3 / OpenBVE

OpenBVE- A free train simulator
http://www.openbve-project.net
269 stars 52 forks source link

Compiler Warnings #63

Open leezer3 opened 8 years ago

leezer3 commented 8 years ago

At present, the Travis-CI builds have ~90 begin compiler warnings, which are mostly missing XML doc comments.

https://travis-ci.org/leezer3/OpenBVE/jobs/122372936

Fixing these is good manners if nothing else. Have made a basic start here: https://github.com/leezer3/OpenBVE/commit/70e656cbb2ba191549255c99629a0b19a9a755d7

WIP :+1:

leezer3 commented 8 years ago

https://github.com/leezer3/OpenBVE/commit/b39801081d44a34f624366b9f30b3eac05679a73

Down to 75 compiler warnings.

leezer3 commented 8 years ago

https://github.com/leezer3/OpenBVE/commit/aa450ffdc2e117c3d7032d7d4b26951a2c947494

Now down to 54 warnings, and have removed a few small bits of cruft too.

leezer3 commented 8 years ago

https://github.com/leezer3/OpenBVE/commit/48d50dcd8d39684af886cab700ddf873ff4bb107

Not a specific compiler warning (Visual Studio's code analysis tool), but I'm trying to get rid of as many of these as possible. Hopefully helps to avoid odd bugs in the future.

leezer3 commented 8 years ago

https://github.com/leezer3/OpenBVE/commit/fbd0a4290adf2fa282ea1949ec91060d2e6a40aa

Some more minor issues. Again doesn't fix any specific compiler warnings, but makes Resharper, FXCop and Gendarme a little happier.

leezer3 commented 8 years ago

https://github.com/leezer3/OpenBVE/commit/14ccf2c0354f1ef715aaaa566c9a2ca20e72f3e8

Down to 47 warnings, plus tidied a few more bits of cruft along the way.

leezer3 commented 8 years ago

Just removed a bunch of spam caused by marking the original security keys as obsolete.....

Leaves us with 27 warnings at the minute, much better than 90.