search

leezer3 / OpenBVE

OpenBVE- A free train simulator
http://www.openbve-project.net
275 stars 52 forks source link

hmmsim1 basic route (seoul subway line2) patternobj and patternend not working #700

Open hwanghyunseo opened 2 years ago

hwanghyunseo commented 2 years ago

Description

patternobj(patternend) code not working

Reproduction

if using patternobj(patternend) code. objects not showing

Route

https://apkpure.com/hmmsim-train-simulator/com.Jeminie.Hmmsim

Train

on the route

Logs

no log

Related information

os=windows 10 x64 pro control=keyboard

etc PatternObj(index, placement interval, placement angle, x, y, object0, object1, ...); Index: Enter the index to use as a value between 0 and 255. Arrangement Interval: Enter the interval to be repeated. Placement Angle: Enter the spacing to be used as the placement angle of the object. x : Enter the relative position of the X axis with respect to the rail. y : Enter the position of the Y axis relative to the corresponding rail. Object : Enter the object index to be repeatedly placed in order. The objects are repeatedly placed in sequence until you finish placing them.

PatternEnd(index); Index : Enter the index at which to end the repeating batch. source:https://web.archive.org/web/20170304031539/http://jeminie.kr/hmmsim2/eng/addon-develop.html to english

leezer3 commented 2 years ago

I wouldn't expect them to be working....

We don't support Hmmsim routes at all at present.

hwanghyunseo commented 2 years ago

I wouldn't expect them to be working....

We don't support Hmmsim routes at all at present.

Can you patternobj,patternend to openbve support code converter (example=freeobj) make? Please https://youtube.com/channel/UCVasMKuG4TjB9fEUlkQ4SpQ this channel likely

leezer3 commented 2 years ago

Will look into it, but may take a little while.

I've fixed the routefile parser to recognise most of the rest of the Seoul Subway line included with Hmmsim, but without PatternObjs, most of the track / ground is missing.

hwanghyunseo commented 2 years ago

Will look into it, but may take a little while.

I've fixed the routefile parser to recognise most of the rest of the Seoul Subway line included with Hmmsim, but without PatternObjs, most of the track / ground is missing.

can you patternobj and patternend support now?

hwanghyunseo commented 2 years ago

Will look into it, but may take a little while.

I've fixed the routefile parser to recognise most of the rest of the Seoul Subway line included with Hmmsim, but without PatternObjs, most of the track / ground is missing.

There is an error with the object going to the right. please fix it. patternobj used. (nightly build)

zbx1425 commented 2 years ago

Please pardon my interruption, but I personally think implementing Hmmsim2 route format might not quite worth the effort. The only routes I know that makes use of this format is Mr. Jeminie's Seoul Metro Line 2 & 7. Other routes on Hmmsim2 usually just uses the BVE4 route format, which provides compatibility with OpenBVE for players wanting to play on PC. So adding this support will probably just cover two routes.

I have to admit this can be a nice addition though. However on the other hand, as the Hmmsim2 route format bears more similarities to the BVE5 route format instead of the BVE4 route format (Non-fixed block length, transition curve, etc.), I think implementing Hmmsim2 support after adapting non-fixed block length (this is planned anyway since BVE5 support is planned) would be more adequate.

hwanghyunseo commented 2 years ago

Please pardon my interruption, but I personally think implementing Hmmsim2 route format might not quite worth the effort. The only routes I know that makes use of this format is Mr. Jeminie's Seoul Metro Line 2 & 7. Other routes on Hmmsim2 usually just uses the BVE4 route format, which provides compatibility with OpenBVE for players wanting to play on PC. So adding this support will probably just cover two routes.

I have to admit this can be a nice addition though. However on the other hand, as the Hmmsim2 route format bears more similarities to the BVE5 route format instead of the BVE4 route format (Non-fixed block length, transition curve, etc.), I think implementing Hmmsim2 support after adapting non-fixed block length (this is planned anyway since BVE5 support is planned) would be more adequate.

The one I mentioned is Hmmsim 1.

zbx1425 commented 2 years ago

Sorry for making the mistake! There are still not many current routes using this though. Still, PatternObj can be useful. On the other hand, Hmmsim1 also makes use of the non-fixed block length track system, so I think this has to be addressed first.

hwanghyunseo commented 2 years ago

760 please fix it. @leezer3

ginga81 commented 2 years ago

Apart from this problem, PatternOBJ command seems such as Bve5's repeater command.

if it is possible to place objects repeatedly, for example, at 5m intervals, regardless of the block length, simply place the rail of the 5m object on the transparent rail, we can create beautiful rail like Bve5. Additionally, Bve5's rail placing, especially not rail0, these placing are incredibely difficult. Because they have to learn mathematics knowledge such as sin(), cos(),tan(), etc... The other hands, OpenBVE's rail placing is block length, basically 25m. So, our rail checking is 1/5 and do not need mathematics knowledge.

I think that it will be extremely convenient because there is no need to make many rails. Currently, we can use cyclerail command, but this command can't use different block length at each rail. If PatternOBJ can put different block length at each rail, it is incredively useful.