Open ginga81 opened 8 months ago
Now that's interesting. If I recall, when these were implemented, the idea was for additional notches to be for ATS plugin use, and blocked off for the driver.
I'm not sure we thought of the situation where the number of power notches available is greater than the actual number of notches available in train.dat Whilst this isn't the immediate problem, perhaps that needs altering too.
First question before anything gets changed: Do you have an actual use for this scenario? I suppose it's easier than just adding zero acceleration notches, but I'm wondering about specifically disallowing it.
Description
relating of https://github.com/leezer3/OpenBVE/issues/952
I received more information from a user who reported that the notch only goes to 2 steps when set to P6. I thought I should submit this as a separate issue.
He said that if DriverPowerNotches is more than PowerNotches, e.g. DriverPowerNotches:24 PowerNotches:6 When ConvertNotches is turned ON, the number of mascon notch of the TYPE-2 controller becomes 2 notches.
So we suggest that shouldn't it be possible to allocate this to P1-5 notches, with the number of stages calculated by dividing 24 by 6? 24/6=4. So, when more notch moves,P5 keeps P4's.
In addition, if we set the value of DriverPowerNotches to be more than PowerNotches, I think it would be better to divide it into an even of average from P1 to P5.
Reproduction
Please prepare a train whose DriverPowerNotches value is set to be greater than PowerNotches.
Route
any
Train
Please prepare a train whose DriverPowerNotches value is set to be greater than PowerNotches.
Logs
This issue isn't crash. So no log.
Related information
My PC's spec: OS:Ubuntu 20.04 LTS 64bit CPU:AMD® Ryzen 7 2700x eight-core processor × 16 Memory:31.3GB Graphic:AMD Radeon RX 590 Series (POLARIS10, DRM 3.40.0, 5.11.0-40-generic, LLVM 12.0.0)
Reported user's spec OS:Windows 10 Home 22H2 build19045.3570
Controller:both environment Densha de GO controller TYPE-2 for PlayStation 2