legrego / homeassistant-elasticsearch

Publish Home-Assistant events to Elasticsearch
https://legrego.github.io/homeassistant-elasticsearch/
MIT License
143 stars 38 forks source link

Remove Elasticsearch v7 Support and no-auth option #279

Open strawgate opened 3 weeks ago

strawgate commented 3 weeks ago

We should consider deprecating Elasticsearch v7 support and when we do so, we should remove no-auth as an option

legrego commented 3 weeks ago

Why do you want to remove the no-auth option?

strawgate commented 3 weeks ago

In ES7, auth is off by default and enabling it is recommended.

In ES8, auth is on by default and disabling it is not recommended.

We can keep it, in not too concerned about this one

legrego commented 3 weeks ago

Yeah understood (I worked on that 🙂). I expect most run with auth, but it feels like a cheap enough feature to leave in for those who don't.

++ to removing v7 support in an upcoming release.