Open strawgate opened 3 weeks ago
consider also adding state_class
Coverage Report
File Stmts Miss Cover Missing __init__.py 0 0 100% elasticsearch __init__.py 112 19 83% 96, 99–101, 104, 110, 119, 137–138, 145–147, 153–154, 174–175, 181, 183, 269 config_flow.py 199 16 91% 163, 196, 326, 390–391, 402–404, 418–419, 423, 501, 576, 585, 619–620 const.py 34 0 100% entity_details.py 59 0 100% errors.py 28 3 89% 51, 60, 67 es_doc_creator.py 191 1 99% 342 es_doc_publisher.py 268 38 85% 142–143, 182, 185, 188, 193, 210–211, 229–232, 236, 251–252, 268–269, 273, 298, 302, 396, 416, 458, 472, 483, 486, 514–515, 517–518, 520–521, 525–527, 546, 548, 554 es_gateway.py 144 20 86% 94–95, 114, 133–135, 137, 139–140, 142–143, 146–148, 153–154, 158–160, 253 es_index_manager.py 149 18 87% 77, 82, 182–183, 255–256, 273–274, 279–280, 309–310, 315, 323–324, 337, 350–351 es_integration.py 35 8 77% 40, 45–46, 57–61 es_privilege_check.py 61 0 100% es_serializer.py 10 1 90% 17 es_version.py 30 0 100% logger.py 2 0 100% system_info.py 25 1 96% 37 utils.py 4 0 100% TOTAL 1351 125 90%
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
221 | 0 :zzz: | 0 :x: | 0 :fire: | 12.796s :stopwatch: |
@legrego good to go!
@legrego 3 open discussions but incorporated the rest of the feedback
Add floors support for devices Add labels support for devices and entities Add unit_of_measure for entities Add class for devices (device_class, ex.
timestamp
) and entities (state_class)Switch dynamic mode from strict to false to ignore extra fields present in the documents instead of failing to index
Bumps Python to 3.12 and minimum HA version to 2024.4.4
Ready to go on everything except updating doc_creator and doc_publisher tests as I want to wait until https://github.com/legrego/homeassistant-elasticsearch/pull/272 merges before updating those tests