search

leichter / cwrx

(Old) Cinema6 API
0 stars 0 forks source link

Beeswax creatives should include a thumbnail. #925

Closed howardengelhart closed 8 years ago

howardengelhart commented 8 years ago

This is necessary to get inventory from some exchanges, notably Mopub. A thumbnail URL will be added to placements created by watchman.

cc: @minznerjosh

leichter commented 8 years ago

@howardengelhart I have code ready to go for this + the backend changes discussed in cinema6/minireelinator#1281. However, I ran into an issue with beeswax where trying to set the creative_thumbnail_url prop with a valid url returns an error with the message "ERROR: URL must begin with HTTP or HTTPS". This happens if you use either an http or https url; but if you instead trim the protocol or make it protocol relative (//c6.com/pixel) the error goes away for some reason.

I sent an email to our tech contact, Shamim, asking about this. My code in the meantime makes all urls protocol relative, which would work for now, but if they fix this logic our code will break, so we probably want to hold off on pushing this for now.