leiweibau / Pi.Alert

Scan the devices connected to your WIFI / LAN and alert you the connection of unknown devices. It also warns if a "always connected" device disconnects. In addition, it is possible to check web services for availability. For this purpose HTTP status codes and the response time of the service are evaluated.
https://leiweibau.net
GNU General Public License v3.0
470 stars 32 forks source link

[Feature Request] Apprise support #192

Closed modem7 closed 8 months ago

modem7 commented 1 year ago

To simplify backend config for notifications, one could utilise Apprise (Github) to allow for multiple notification services, without having to manually add configurations for all of them.

Requirements:

  1. Apprise (Pypi) added to install/update scripts.
  2. Relevant backend config added
  3. Readme updated as it could introduce a breaking change if other methods (NTFY, Mail, Pushover, Pushsafer, Telegram) are removed in favour of apprise config.
  4. @jokob-sk would need to update the Docker image to reflect changes.

This would definitely require some thinking and testing, but I think it would reduce configuration and backend changes later down the line for notifications.

jokob-sk commented 1 year ago

@modem7 Please note my fork has already Apprise supported and leiweibau's and my codebase are very different at this point https://github.com/jokob-sk/Pi.Alert image

modem7 commented 1 year ago

@modem7 Please note my fork has already Apprise supported and leiweibau's and my codebase are very different at this point https://github.com/jokob-sk/Pi.Alert image

Understood! Thank you for replying!

Thought I'd ping you in as you're part of the readme!

jokob-sk commented 1 year ago

Thanks for the ping, let me know if you have any questions - happy to answer 😉

leiweibau commented 1 year ago

And I use shoutrrr, to connect to different Services, like Telegram

Thought I'd ping you in as you're part of the readme!

We started together and helped each other along, so @jokob-sk is in the readme.