leiweibau / Pi.Alert

Scan the devices connected to your WIFI / LAN and alert you the connection of unknown devices. It also warns if a "always connected" device disconnects. In addition, it is possible to check web services for availability. For this purpose HTTP status codes and the response time of the service are evaluated.
https://leiweibau.net
GNU General Public License v3.0
342 stars 25 forks source link

[Feature Request] Improvements to the list of predefined filters #257

Closed leiweibau closed 5 months ago

leiweibau commented 5 months ago

From @TheCableGuy99

Thanks for the feedback

leiweibau commented 5 months ago

Can we add the ability to "edit" the filters as well once created?

This will probably not be implemented, as the creation of a new filter is really very easy. The current search term is even taken from the device list search if something is already entered there. The work involved in building another dialog box, entering the translations and implementing the readout and saving via the backend is too much for me at this point.

I'll have to think about the other two points first. Maybe we can think together later about how to implement something that is reasonable in terms of the effort required.

TheCableGuy99 commented 5 months ago

Fair enough, I know it's fast to implement again if anything needs changing/editing so it's not really a problem. Thanks for considering it.

leiweibau commented 5 months ago

test

A quick thought about the sketch. If no value is saved in the fields, the filters are sorted in alphabetical order. If values are saved, the filters are sorted according to these values. If a value exists twice or more, then sorting within this "group" is again alphabetical. I don't know how SQLite3 sorts the table if there is a mixture of empty and filled fields. Either the entries are at the top or at the bottom. 🤷‍♂️ What do you think?

TheCableGuy99 commented 5 months ago

So I don't know if this is possible but what I had in mind was like a tree system.

You can define a sub heading and have some filtered in that, then you can have another sub heading and more filters under that and so on. Each sub heading just expands by clicking a "+" symbol.

Then each is sorted alphabetically if you don't specify and order under the applicable sub heading, but if you do then it's done as per the numbering. If 2 numbers are entered the same and it's not intelligent enough to pick that up then those two are sorted alphabetically amongst each other.

Lastly, is it not possible to sort them up and down manually with the mouse by dragging them? That's a nice feature.

I also came across a problem today when sorting and that's because it takes each category into account when deciding what goes in the new filter. To really make this user friendly you need to be able to specify which category to be searching in when adding this to the chosen filter. Otherwise, it adds things with similar words.

For example, I have 2 properties physically networked together. In one property I have "Mums Conservatory". In there might be "Gary's Nintendo Switch". Now if I want all "Mums" items to go into a new category called "Mums Items" and I search for "Mum" it will add Gary's Nintendo Switch in there because it's in "Mums Conservatory". So the ability to say just search under "Owner" category, or other category is a big help.

Thanks for all your hard work, it's really a great project and my favourite.

leiweibau commented 5 months ago

I also came across a problem today when sorting and that's because it takes each category into account when deciding what goes in the new filter. To really make this user friendly you need to be able to specify which category to be searching in when adding this to the chosen filter. Otherwise, it adds things with similar words.

Yes, I've already stumbled across that too. I will work on that first.

leiweibau commented 5 months ago

In principle, there is now an editor for the filters 😉 However, this is not as easy to access as the delete function, but is located on the settings page -> GUI, as I sketched out above.

What I have not implemented:

What was implemented:

What still needs to be changed/done:

Settings Page

dev

I will make the buttons yellow instead of red

Sidebar

dev2
leiweibau commented 5 months ago

Update released with https://github.com/leiweibau/Pi.Alert/commit/c96da56cd10c277feca9c36fc1b45e715f00bf2b