leiweibau
commented
7 months ago Thanks for the kind words.
When you pause the scans for a specific time (10 minutes, 15, etc.) in Settings, the ARP scans indeed stop, but none of the other scans (neither the Internet IP scans nor the Speedtests).
Of course, you're right. I still need to make adjustments here. This function is not only important for the backup, but also for the update. Thanks for the hint.
Hi! First of all, congratulations on your excellent work with Pi.Alert. It's a fantastic tool. I'm new to this, but I've been reviewing the functionality and some of the code, and I believe I've found a bug:
When you pause the scans for a specific time (10 minutes, 15, etc.) in Settings, the ARP scans indeed stop, but none of the other scans (neither the Internet IP scans nor the Speedtests). I haven't tested the rest of the scans, but based on the code, it seems they wouldn't stop either.
This could be a problem if, for example, a DB backup is being performed just at the moment when it's scanning the Internet IP and detects a change or doing a Speedtest, recording results in the DB, potentially leading to DB corruption. In the text next to the "Toggle Scans (on/off)" button, it indicates "Switches all scans of Pi.Alert on or off," but this is not the case. It only stops the ARP scans, and the rest remain active, potentially causing DB corruption if a change occurs in the other scans while a DB backup is in progress.
Thank you again for your great work!