search

lelandpaul / ringingroom

A space where socially-distanced ringers can practice together.
GNU General Public License v3.0
23 stars 12 forks source link

Handbell images overlap user label #247

Open centreboard opened 3 years ago

centreboard commented 3 years ago

  1. It can completely overlap, so you can't easily assign users to the top right bell (e.g. the 7 on 10 bells) image

  2. As you go around the circle it swaps from the bell being under to on top of the label at the top of the circle. image

It could be fixed by moving the label on the top 2 bells (i.e. 6 & 7 on 10 bells) higher. It currently looks a bit below where it would be on a circle. On 16 bells it looks like it would need to be the top 4 bells to avoid overlap.

image

kneasle commented 3 years ago

I wonder... would it be possible to do the layouting dynamically using JS instead of using a crazy amount of SASS preprocessing and long if chains? It seems to me that if the handbells and their labels were positioned dynamically in two concentric rings then this problem would disappear... I think it would make the code easier to maintain as well as making new tower sizes work automatically. I nearly made a PR for this a while ago (complete with animated rotations) but I couldn't figure out how the scaling code works and other things took over my time...