lenovo / lenovo-wwan-unlock

FCC and DPR unlock for Lenovo PCs
27 stars 5 forks source link

Insure the working directory is the same as the script #7

Closed pseudocc closed 4 months ago

pseudocc commented 5 months ago

Fixes: #6

mrhpearson commented 5 months ago

Neat solution - looks good to me. Thank you!

@nitinexclusively - any concerns?

nitinexclusively commented 4 months ago

@pseudocc Thank you for the contribution and Sorry for my late reply. I think, you have downloaded package from lenovo website instead of coning using github

u@Mersey-1:$ tar xf lenovo_wwan_fccunlock_package_release2.tar u@Mersey-1:$ sudo lenovo_wwan_fccunlock_package/fcc_unlock_setup.sh

I would recommend to clone it using github and then try executing script . For normal users, even with this changes you can see error, if fcc_unlock_script.sh is moved to some other unknown directory. let me know , if you have any comment.

pseudocc commented 4 months ago

Reply to @nitinexclusively

I think, you have downloaded package from lenovo website instead of coning using github

No, it's the package you uploaded to the launchpad.

Further explanation

It's not related to the way we get the package, the problem is that you have to cd into the directory to run the setup script.

$ git clone git@github.com:lenovo/lenovo-wwan-unlock.git
$ # the following command will fail
$ sudo lenovo-wwan-unlock/fcc_unlock_setup.sh
$ # currently the way to install the package
$ cd lenovo-wwan-unlock # cd is required
$ sudo ./fcc_unlock_setup.sh
nitinexclusively commented 4 months ago

No, it's the package you uploaded to the launchpad.

Understood now !

Further explanation

It's not related to the way we get the package, the problem is that you have to cd into the directory to run the setup script.

For this changes looks OK to me . Thank you for the contribution !