search

leptos-rs / leptos

Build fast web applications with Rust.
https://leptos.dev
MIT License
16.39k stars 655 forks source link

Bump MSRV to 1.8, so we can drop lazy_static #2726

Closed martinfrances107 closed 1 month ago

martinfrances107 commented 3 months ago

To me this is minor housekeeping, but I wanted to generate an issue, so this may inform those who are not focused on the detailed flow of PR's. But want changes to Architecture ( or the to tool/infrastructure ).

I want to reduce the attack surface by droping the crate "lazy_static" as the functionality has now been stabilized in std ( as of last weeks release of rust 1.8)

This issue has the awkward aspect that we must bump the MSRV to rust 1.8.

I plan to generate two PR for this isuse.. one for changes to the library only and one for changes to the examples.

For reference see the "Stabilized API" section of the release notes here release notes

rakshith-ravi commented 3 months ago

Thanks for the PR @martinfrances107! If I may add my two cents here - Would it make sense to add this for 0.8? Might give people some time to upgrade

martinfrances107 commented 3 months ago

Would it make sense to add this for 0.8? Might give people some time to upgrade

In #2767, the current propposal , the examples and the benchmark sub-modules bump to 1.80 The underlying library is unchnaged (rust-version = "1.75" )

rakshith-ravi commented 1 month ago

Closing this since #2767 is merged. Feel free to reopen it in case I'm missing something