search

levaleureux / dr_spec

rspec like for dragonruby
The Unlicense
0 stars 2 forks source link

Add Smaug support. #48

Closed iMacTia closed 11 months ago

iMacTia commented 11 months ago

This is achieved by using require_relative rather than require. This removes the assumption that the library is installed in the lib/dr_spec folder. Add alternative Smaug install instructions to README.

levaleureux commented 11 months ago

Hi, thanks a lot for this PR I truly apreciate it as smaug is a big thing I'm happy that this lib can help.

My main concern is more on the readme. As Dragonruby emphasis the simplicity and some stand-alone example. I think it would be better to add as first section of the readme a section who explain how to use it without smaug. Make a the learning curve as easy as possible is a key point on a small user base like Drangonruby. Please do a little how to. I will test it by following it on a small project and validate it.

Thanks again for your time

iMacTia commented 11 months ago

@levaleureux I've rebased against develop and improved the README. Please let me know what you think 🙏 !

levaleureux commented 11 months ago

Hi I haven't the time to test it but afert looking de the readme and code it look ok for me.

iMacTia commented 11 months ago

Thank you @levaleureux, that's OK I have the other PRs to propose as well. We can leave all changes in develop until you have time to test and then we can move them to master 👍 I can point to the develop branch with Smaug so I don't really mind 😄