lewis6991 / satellite.nvim

Decorate scrollbar for Neovim
MIT License
542 stars 20 forks source link

feat: add scrollbar background color #64

Closed Angelchev closed 8 months ago

Angelchev commented 8 months ago

Add configurable scrollbar background color

Close #52

Screenshots

White White & Winblend 50 Cyan Cyan & Winblend 50 Pink Pink & Winblend 50
White White + Winblend 50 Cyan Cyan + Winblend 50 Pink Pink + Winblend 50

Potential Issues

Angelchev commented 8 months ago

After some additional testing on a GUI like neovide I have encountered some highlighting issue that may need fixing:

Scrollbar center highlighting should be SatelliteBar instead of the SatelliteBackground.

Screenshot (Cyan background for clarity)

Screenshot_20231229_172717


Will look into fixing this soon.

Angelchev commented 8 months ago

I have double-checked and it looks like the above issue was just due to some local dev changes. It works just fine in the PR:

Neovide screenshot (Cyan background for clarity)

Screenshot_20240101_201806

As you can see the background color of the extended marks for git is not changed, but I personally think this is OK, or can be added later.

@lewis6991 feel free to merge if happy :)

lewis6991 commented 8 months ago

By default I'd prefer the background to be transparent like it is now.