search

lgarron / folderify

:file_folder: Generate pixel-perfect macOS folder icons in the native style.
MIT License
1.56k stars 39 forks source link

Incorrect icons when using `Rez` for assignment #75

Closed rktprof closed 11 months ago

rktprof commented 1 year ago

The folder icons were updated at some point, so when creating icons for macOS Ventura the icons doesn't look right

Here is an example of a generated icon on the left and a standard icon on the right (from two Get Info windows) Screenshot 2023-09-04 at 11 41 34

lgarron commented 1 year ago

Hmm, there are a couple of potential reasons you could be seeing a difference in icons. Could I ask you to upload and share the .iconset of your icon when it's not assigned to a folder, in both light and dark mode?

folderify --color-scheme light input.png && mv input.iconset light.iconset
folderify --color-scheme dark input.png && mv input.iconset dark.iconset
rktprof commented 1 year ago

Interesting, after some more testing it seems to only happen when using direct assignment to a folder:

folderify /path/to/mask/godot.png /path/to/target/folder
folderify --output-iconset /path/to/output/godot.iconset /path/to/mask/godot.png /path/to/target/folder

gives me the incorrect icon assigned to the target folder, but the output iconset seems to be correct godot dark.iconset.zip godot light.iconset.zip godot mask

I'm running macOS 13.4 Dark mode on an M1 Max Macbook Pro, installed folderify using Homebrew

lgarron commented 1 year ago

Okay, I suspect this is an issue with the icon assignment, possibly related to https://github.com/lgarron/folderify/issues/71#issuecomment-1518927085

It might be worth looking at https://github.com/sveinbjornt/osxiconutils again.

I don't know when I'll have time to look into this, but I definitely want to get to the bottom of it.

Eejit43 commented 1 year ago

I'm experiencing this issue as well when using the direct assignment to a folder. Any workarounds? It is a minor difference but it is bugging me a bit

Eejit43 commented 1 year ago

@lgarron instead of osxiconutils, https://github.com/mklement0/fileicon seems to work like a charm! Folder looks correct when using that, aside from minor coloring and shadow differences (but that's a different issue I believe).

Opa- commented 11 months ago

I'm experiencing some color difference too, especially noticeable in columns mode : image

Using folderify 3.0.13 with Ventura 13.6.3 (22G436)

Here's a zip containing the input png and the generated iconset if that helps iconset.zip