search

lgarron / folderify

:file_folder: Generate pixel-perfect macOS folder icons in the native style.
MIT License
1.56k stars 39 forks source link

16x16 folder icons very low quality #86

Closed t3rminus closed 6 months ago

t3rminus commented 6 months ago

I used folderify to add a "no entry" sign to a folder. Most sizes look good! But the 16x16px size looks off, and the little jaggy opaque corners and weird "glow" line at the bottom of the image are catching my attention and tripping me up. See attached screenshot.

Any help would be appreciated!

Generated on M3 MBP, Sonoma 14.4.1

image

lgarron commented 6 months ago

That looks like you're using a very old version of folderify. What version are you running?

t3rminus commented 6 months ago

% folderify --version folderify 3.2.4

Just installed today using brew install folderify

lgarron commented 6 months ago

Hmm, would you mind sharing your mask file and output .iconset images? I can take a closer look.

t3rminus commented 6 months ago

Here's the mask image, iconset, and icns file. The command used to generate the result was simply folderify 1.png. 1 1.iconset.zip 1.icns.zip

It's strange... the iconset looks fine, but the resulting icns file looks weird in preview (the sidebar thumbnails are yellow instead of blue, although clicking on the thumbnail seems to display it correctly).

image

I also want to note that I wasn't able to reproduce this on my built-in mac display, or my 4K Dell monitor at home. It only seemed to be an issue when generating icons on my 1080p ASUS monitor at the office. Maybe it has to do with the active display colorspace or calibration at the time the icon is generated, or it simply only affects lodpi monitors?

t3rminus commented 6 months ago

Second note: This issue only seems to occur when running the command folderify 1.png to generate the icns first, then copy+pasting or dragging+dropping it into the icon slot in the Get Info window of a file/folder.

It does not seem to occur when doing folderify 1.png /path/to/dest. If you use folderify to set it directly, the result looks different (foo set directly, foo2 set manually): image

lgarron commented 6 months ago

Yeah, there are all sorts of subtle details when it comes to resource forks and icons. 😢

I don't think there's much for folderify to do, as setting the icon directly is core functionality. If enough people run into this, we can consider adding a caution message when folderify is invoked without a target.

If you personally need to to assign .icns icons often, I suggest installing https://formulae.brew.sh/formula/fileicon or using osascript directly: https://formulae.brew.sh/formula/fileicon