Code cleanup and bug fixes

liavt / Scheduler

Scheduler for school.

https://liavt.github.io/Scheduler

MIT License

1 stars 1 forks source link

Closed PoisonNinja closed 8 years ago

PoisonNinja commented 8 years ago

Quick summary:

Rearranged code into logical sections
New file called Changelog.md that contains all the changes between versions (perhaps we can have a changelog button in About)
Renamed Settings -> About
Function to generate HTML code. No need to repeat the same code over and over when a function could have done it way easier
Include 9:30 as part of school. Previously, school started at 9:31 according to the schedule, which is wrong.
Formatting updates so it's easier to read

PoisonNinja commented 8 years ago

On a side note, why was Code.gs renamed to Code.js? You can't load .js files in Google Scripts

PoisonNinja commented 8 years ago

I forgot some changes:

Rename onOpen -> firstRun, since that's the only time it actually gets run
Confirm that this is the first time that you clicked it when you press on the button that says "Click Here on First Use"

PoisonNinja commented 8 years ago

Unified listAll function. No need to have 3 different functions that do essentially the same.

PoisonNinja commented 8 years ago

Rebased on latest upstream changes

PoisonNinja commented 8 years ago

@liavt can you give me write access? It's annoying to have to keep rebasing my changes.

liavt commented 8 years ago

Added as contributor. I also merged this into the main branch.