Add Serialization for our Units

libmir / asdf

JSON library

http://asdf.libmir.org

Boost Software License 1.0

20 stars 8 forks source link

Add Serialization for our Units #14

Closed keivan-sl closed 3 years ago

keivan-sl commented 3 years ago

Add serialization for common unit functions: toString and getRawValue
Based on asdf:master:v0.7.1

thewilsonator commented 3 years ago

Couple of things:

Please add test cases.
Why is alias serialize = toString; and alias serialize = getRawValue insufficient for you use case here?

keivan-sl commented 3 years ago

@thewilsonator Sorry, my bad. This was meant to be a local PR to our forked master and not on asdf:master. The issue was that we did not want to make changes to our original library and hence we were adding the needed changes to asdf temporarily. Closing this PR.

thewilsonator commented 3 years ago

No problems.