search

liesel-devs / liesel

A probabilistic programming framework
https://liesel-project.org
MIT License
40 stars 2 forks source link

Rename Data -> Value; keep old name as an alias #170

Closed jobrachem closed 1 month ago

jobrachem commented 10 months ago

This PR goes back to a suggestion made by @Seb-Lorek :

I find the naming of the node "Data" a bit unfortunate. I would have thought of Fixed or something like that. When you think of Data, you generally think of oberved data in the model. Also the description: "A Node subclass that holds constant data.". Doesn't help, it reminded me more of observed data. (Thought the description somehow fit: "Constant values better.")

I am not sure whether I am entirely happy with Const, because this class is also used as the lsl.Var.value_node of strong variables. If they are parameters, the values are not actually constant, but updated during sampling. So maybe Value would be better than Const. What do you guys think @GianmarcoCallegher @wiep? Of course this PR is not super urgent, so no need to prioritise it right now,

wiep commented 9 months ago

The name Const would suggest that the value is constant and immutable. From the two options, I like Value better.

GianmarcoCallegher commented 8 months ago

Is this ready for a review?

jobrachem commented 8 months ago

No, the name change is not implemented in the way it is supposed to be.

jobrachem commented 1 month ago

@GianmarcoCallegher this is finally ready for review 😊

jobrachem commented 1 month ago

Since the docs actions had not completed for a while, I pushed a minor commit (an addition to the gitignore) to trigger a new build.