Turn off update_on_init for special model nodes

liesel-devs / liesel

A probabilistic programming framework

https://liesel-project.org

MIT License

38 stars 2 forks source link

Turn off update_on_init for special model nodes #186

Closed jobrachem closed 3 months ago

jobrachem commented 3 months ago

The adoption of #92 caused warnings to be logged by default during model initialization, because the special nodes for the log likelihood and log probability cannot always be updated directly on their initialization. This PR just sets update_on_init=False for these nodes, which solves the issue.

jobrachem commented 3 months ago

@GianmarcoCallegher can you do the review?

GianmarcoCallegher commented 3 months ago

Makes sense