search

liesel-devs / liesel

A probabilistic programming framework
https://liesel-project.org
MIT License
40 stars 2 forks source link

Unpin numpy version #199

Open jobrachem opened 4 months ago

jobrachem commented 4 months ago

See this comment:

https://github.com/liesel-devs/liesel/pull/198#issuecomment-2248741496

The issue in the CI does not originate from scipy, but instead from incompatibility of tensorflow probability to numpy 2.0. At first, I could not reproduce the issue locally, because locally, I installed using the pmc specs, and pymc currently pins to numpy<2.

The current solution is to pin numpy in liesel to <2.0, too, until the downstream issue is addressed. There's already an issue in the tensorflow probability repo:

Once this is addressed, we can unpin numpy, since pymc correctly handles its dependency on numpy itself.

Originally posted by @jobrachem in https://github.com/liesel-devs/liesel/issues/198#issuecomment-2248741496

wiep commented 2 weeks ago

We are not the only one waiting for it to be solved.

wiep commented 5 days ago

TFP v0.25 has been released. https://github.com/tensorflow/probability/releases/tag/v0.25.0

jobrachem commented 4 days ago

Does not seem like the linked issue is fixed though :/