liftmodules / widgets

A collection of useful widgets for use with Lift
12 stars 18 forks source link

No longer compiles for Lift 2.6 #19

Open d6y opened 9 years ago

d6y commented 9 years ago

The widgets source code is no longer compatible with Lift 2.6. I don't think this is a problem. I propose to modify the build.sbt to specify Lift 3.0-SNAPSHOT.

When compiling with Lift 2.6 the error is:

[info] Compiling 25 Scala sources to /Users/richard/Developer/lift/modules/widgets/target/scala-2.11/classes...
[error] /Users/richard/Developer/lift/modules/widgets/src/main/scala/net/liftmodules/widgets/autocomplete/AutoComplete.scala:181: value liftPath is not a member of object net.liftweb.http.LiftRules
[error]       val what: String = encodeURL(S.contextPath + "/" + LiftRules.liftPath + "/ajax/"+ S.renderVersion+"?"+func+"=foo")
[error]                                                                    ^

and

[error] /Users/richard/Developer/lift/modules/widgets/src/main/scala/net/liftmodules/widgets/tree/TreeView.scala:120: value liftPath is not a member of object net.liftweb.http.LiftRules
[error]              "/"+LiftRules.liftPath + "/ajax/"+ S.renderVersion)+"?"+key+"=_"
[error]                            ^
[warn] three warnings found
[error] two errors found

There are also deprecation warnings about deprecations to @deprecations. Which is my all time favourite deprecation.

Shadowfiend commented 9 years ago

Lol. Certainly if we're referencing liftPath it seems like the snapshot should be for 3.0-SNAPSHOT, yeah.

fmpwizard commented 9 years ago

I haven't checked if this is already the case, but I would say do a build for lift 2.6 scala 2.11 and then bump the widgets to 1.4-SNAPSHOT and have it only build for 2.11 and lift 3.0-SNAPSHOT

d6y commented 9 years ago

It looks like I didn't publish 2.6 (non-snapshot) versions of the modules when 2.6 came out. So I'll do that before anything else; and then bump the version number up and switch to 3.0-SNAPSHOT.