search

liip / LiipTranslationBundle

Tools for translation management
MIT License
25 stars 11 forks source link

Git storage #23

Closed thormeier closed 9 years ago

thormeier commented 9 years ago

Add GitPersistence and some SF2 commands based on YamlPersistence to make sure the translation files are stored in a Git repository

lsmith77 commented 9 years ago

test failure seems to be unrelated to this PR for the memory issue I would recommend something like this: https://github.com/symfony-cmf/RoutingBundle/blob/master/.travis.yml#L24

dbu commented 9 years ago

restarted the build, now that build is fixed in master

lsmith77 commented 9 years ago

btw .. while you are at it .. can you change the notification for travis to liip:3QOs1QKt3aCFxpJvRzpJCbVZ ?

dbu commented 9 years ago

notifications are not related to this PR. did #26 to do that.

dbu commented 9 years ago

@thormeier can you please rebase this PR on master?

thormeier commented 9 years ago

Rebased onto master, waiting for Travis to pass this.

krtek4 commented 9 years ago

Seems ok to me :)

Just one thing bothers me a bit. The git commands are separated between the InitCommand and the GitPersistance, maybe put everything in GitPersistance. This would also enable creation of the repository from the application.