liip / LiipTranslationBundle

Tools for translation management

MIT License

25 stars 11 forks source link

fix travis build #25

Closed dbu closed 9 years ago

dbu commented 9 years ago

23 and #24 both see build failures unrelated to their changes. lets see if this fixes it.

dbu commented 9 years ago

looking at the travis build, there seems to be some regression/change/mock problem with symfony 2.6+

anybody with more insight into the library got time to investigate a bit? @thormeier maybe?

jeanmonod commented 9 years ago

Hi all,

I just take a deeper look at the build status. There is two issues:

In 2.6, there is the non regression test about languages fallback that fail. This is strange, and I suspect that Symfony change something regarding the mechanism used. Do we know if this fallback cascade is still configured like that in the core of 2.6?
In 2.7, there is a lot of errors related to "PHP Deprecated". How can we avoid that? Is there a setting to allow test pass even if there is deprecated detected?

@dbu, @thormeier, @gnutix I will need help on both subject. I'm currently quite far from the SF2 project...

acrobat commented 9 years ago

@jeanmonod maybe you can use this fix to silence the deprecation warnings symfony/symfony#13033

dbu commented 9 years ago

no idea why one single thing with hhvm now fails. but we can add it to allowed failures i guess, until somebody needs it and wants to fix it.

the deprecation thing seems to not have worked. @acrobat do you see what i did wrong?

acrobat commented 9 years ago

@dbu don't know what's wrong, this is what they have currently in their phpunit.xml. Maybe the extra line with php -r ...does the trick?

dbu commented 9 years ago

the php -r ... was just a more explicit way of explaining what they do... did not get things to work from phpunit file, but with bootstrap.php, as in https://github.com/symfony-cmf/Testing/pull/85/files

but the next thing is that some twig compiler thing produces a fatal error because they add a deprecation without a ; in between. whatever. lets fix tests for 2.6 and wait a bit until 2.7 becomes usable.

acrobat commented 9 years ago

Yeah I wasn't sure about the extra comment, would be really strange if that was the problem :p But the change in the bootstrap file that's maybe the "best" (or the cleanest) fix!