liip / LiipTranslationBundle

Tools for translation management
MIT License
25 stars 11 forks source link

Support for doctrine storage #33

Open yellow1912 opened 9 years ago

yellow1912 commented 9 years ago

Hello,

Given that Doctrine is the primary lib used in SF2, is there any plan to implement support for it soon?

dbu commented 9 years ago

afaik nobody at liip uses doctrine to store translation at the moment so we don't have plans to do that. if you want to contribute an implementation however, please do.

jeanmonod commented 9 years ago

This should be pretty easy, you just have to implement the following interface: https://github.com/liip/LiipTranslationBundle/blob/master/Persistence/PersistenceInterface.php

yellow1912 commented 9 years ago

I will try that tomorrow and see how it goes :). I may not have time to add unit tests for it yet tho.

jeanmonod commented 9 years ago

Cool, just be aware of this before starting: PersistenceInterface.php#L11

jeanmonod commented 9 years ago

@lsmith77 @thormeier As you are doing maintenance on that bundle, I think this is the most important story to implement if we want to give visibility on the bundle...

maZahaca commented 9 years ago

Has anybody succeeded with adding Doctrine to the bundle?

yellow1912 commented 9 years ago

While I no longer use this bundle, we have a private bundle that is inspired with liip theme's code and we are supporting doctrine based twig templates as well as css/javascripts.

I will do a write up on this topic hopefully in the next week to help others on this part.

maZahaca commented 9 years ago

@yellow1912 ok, maybe you can share your bundle to public?

yellow1912 commented 9 years ago

@maZahaca not a big problem, only that we don't have enough tests for it yet so we do not want to publish something untested until we are more ready

maZahaca commented 9 years ago

@yellow1912 I guess this is normal to have unstable branches on the way to tags and stable releases. Anyway, when you will ready let me know :boar: For now I'll try with this bundle.

marcelglaeser commented 8 years ago

Hello @yellow1912 , how works your private bundle and can you share it with us? Thanks Marcel

maZahaca commented 8 years ago

The crowd wants to be shared an amazing code!

marcelglaeser commented 8 years ago

And an own fork for us? :)

maZahaca commented 8 years ago

fork to everyone :) just to improve this code a bit more

yellow1912 commented 8 years ago

I'm sorry, I didnt notice all these notification just now. I have ported Liip theme to use Doctrine Storage, however I haven't done so for Translation. I will have to do so very soon though, since our project will need that within a month. I will be sure to open source it since I may not have time for unit testing and will welcome all unit tests. I'm thinking if I need to use LiipTranslation however. Our project is pretty custom and we may not need something as complicated as this bundle. In anycase I will try to make it as re-useable as possible while not trying to impose lots of constraints and assumptions on it.