Closed dbu closed 9 years ago
i just restarted the build of master for symfony 2.7 and the compatibility problem seems not introduced in this PR but a general issue.
is there a regression in 2.7?
/cc @aitboudad
@aitboudad my question is because the travis tests are failing with 2.7
@lsmith77 not sure I'll check :)
fixed by #37
thx!
as the symfony 2.7 seems to be more complicated (see #37) can we just marge these changes already, even though the 2.7 tests are red?
it seems we do not have functional tests that reveal this problem, but the reason for this is that https://github.com/symfony/symfony/commit/b7770bcfd0ca9341aeada2bc003d505fa95236f8 added https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/LoggingTranslatorPass.php which decorates the default
translator
with the LoggingTranslator.as we do not want just any translator alias injected, but the translator of this bundle, we should be explicit in the service definition. unless people where messing with the
translator
alias, this change is BC.