search

lilmuckers / magento-lilmuckers_queue

A generic multi-adapter queuing system for magento.
MIT License
58 stars 21 forks source link

Added Modman support, rename license file so it can be copied to root #2

Closed philwinkle closed 11 years ago

lilmuckers commented 11 years ago

hmm, Wouldn't it be better to leave the LICENSE.txt as that filename, and then make modman move it to app/code/community/Lilmuckers/Queue/LICENSE.txt ?

philwinkle commented 11 years ago

That's totally doable, but if someone's not using modman and they use ditto or cp -R it'll overwrite

On Tue, Aug 13, 2013 at 1:02 PM, Patrick McKinley notifications@github.comwrote:

hmm, Wouldn't it be better to leave the LICENSE.txt as that filename, and then make modman move it to app/code/community/Lilmuckers/Queue/LICENSE.txt ?

— Reply to this email directly or view it on GitHubhttps://github.com/lilmuckers/magento-lilmuckers_queue/pull/2#issuecomment-22580451 .

Follow me on Twitter - @philwinkle Friend me on Facebook - http://www.facebook.com/philwinkle

lilmuckers commented 11 years ago

Well, that's a bit of a problem for them - modgit and modman will do it properly

Just that the filename "LICENSE" is the general convention for this kinda thing.

On 13 Aug 2013, at 18:04, Phillip Jackson notifications@github.com wrote:

That's totally doable, but if someone's not using modman and they use ditto or cp -R it'll overwrite

On Tue, Aug 13, 2013 at 1:02 PM, Patrick McKinley notifications@github.comwrote:

hmm, Wouldn't it be better to leave the LICENSE.txt as that filename, and then make modman move it to app/code/community/Lilmuckers/Queue/LICENSE.txt ?

— Reply to this email directly or view it on GitHubhttps://github.com/lilmuckers/magento-lilmuckers_queue/pull/2#issuecomment-22580451 .

Follow me on Twitter - @philwinkle Friend me on Facebook - http://www.facebook.com/philwinkle — Reply to this email directly or view it on GitHub.

philwinkle commented 11 years ago

Agreed. Will update the PR.

On Tue, Aug 13, 2013 at 1:12 PM, Patrick McKinley notifications@github.comwrote:

Well, that's a bit of a problem for them - modgit and modman will do it properly

Just that the filename "LICENSE" is the general convention for this kinda thing.

On 13 Aug 2013, at 18:04, Phillip Jackson notifications@github.com wrote:

That's totally doable, but if someone's not using modman and they use ditto or cp -R it'll overwrite

On Tue, Aug 13, 2013 at 1:02 PM, Patrick McKinley notifications@github.comwrote:

hmm, Wouldn't it be better to leave the LICENSE.txt as that filename, and then make modman move it to app/code/community/Lilmuckers/Queue/LICENSE.txt ?

— Reply to this email directly or view it on GitHub< https://github.com/lilmuckers/magento-lilmuckers_queue/pull/2#issuecomment-22580451>

.

Follow me on Twitter - @philwinkle Friend me on Facebook - http://www.facebook.com/philwinkle — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/lilmuckers/magento-lilmuckers_queue/pull/2#issuecomment-22581198 .

Follow me on Twitter - @philwinkle Friend me on Facebook - http://www.facebook.com/philwinkle