search

linagora / tmail-backend

GNU Affero General Public License v3.0
31 stars 17 forks source link

[SANDBOX] AddressContactQueue and its dead letter queue is created in default '/' vhost #1007

Closed quantranhong1999 closed 3 months ago

quantranhong1999 commented 3 months ago

Why

Even if we specify the vhost e.g. sandbox:

Image

Meanwhile, the remaining contact related queues are created in the correct vhost:

Image

This happens for tenant-upn or postgres tenants also.

We need to provide a good isolation.

How

Try to reproduce in tests and debug.

DoD

Fixed.

Arsnael commented 3 months ago

Weird I thought I did a fix regarding that, maybe still not enough

Arsnael commented 3 months ago

=> https://github.com/linagora/tmail-backend/pull/944

I thought that was enough to plug the vhost param to the email adress contact rabbitmq conf but maybe I missed something...

However I just managed to see that if you add the vhost in the uri, it works.

Arsnael commented 3 months ago

https://ci.linagora.com/linagora/lrs/saas/tools/helm-charts/tmail-backend/-/merge_requests/46

I think if we have the vhost for the normal uri, makes sense for address contact uri as well. Might affect the creation of the queue and the link.

Anyways this works and solves the issue (keep getting conflicts these days between sandbox and other envs quorum/not quorum on that queue)

quantranhong1999 commented 3 months ago

Anyways this works and solves the issue (keep getting conflicts these days between sandbox and other envs quorum/not quorum on that queue)

I am more or less done with sandbox. Please feel free to override it now.

Arsnael commented 3 months ago

Still better to have that queue in its vhost like all the others though :)