search

linagora / tmail-backend

GNU Affero General Public License v3.0
31 stars 17 forks source link

ISSUE-1006 Fix CalendarEvent reply extension throw serverFail error #1011

Closed vttranlina closed 3 months ago

vttranlina commented 3 months ago

resolve https://github.com/linagora/tmail-backend/issues/1006

quantranhong1999 commented 3 months ago

Can you deploy this fix on preprod? @tddang-linagora may appreciate it :-)

Arsnael commented 3 months ago

https://james-jenkins.lin-saas.com/job/Tmail%20build/job/PR-1011/1/

Related

chibenwa commented 3 months ago

How about over compatibility modes?

Especially the outlook one can be handy for CNB...

Don't you mind @vttranlina to ensure there is a test for those Outlook events?

vttranlina commented 3 months ago

How about over compatibility modes?

we can declare in jvm.properties https://www.ical4j.org/compatibility/

Don't you mind @vttranlina to ensure there is a test for those Outlook events?

What exactly testing?

chibenwa commented 3 months ago

we can declare in jvm.properties

I tried on tmail.linagora.com but it was not successful.

vttranlina commented 3 months ago

we can declare in jvm.properties

I tried on tmail.linagora.com but it was not successful.

I just tested It works on my local

I added the property: ical4j.unfolding.relaxed=true to jvm.properties And print the CompatibilityHints.isHintEnabled(CompatibilityHints.KEY_RELAXED_UNFOLDING) value in CalendarEventParsed, it accepts the value from jvm.properties

Arsnael commented 3 months ago

I just tested It works on my local

With the code changes of this PR needed, correct?

vttranlina commented 3 months ago

I just tested It works on my local

With the code changes of this PR needed, correct?

Not need, This PR just set ical4j.unfolding.relaxed=true by default. (before that, ical4j set false by default)