search

linagora / tmail-backend

GNU Affero General Public License v3.0
30 stars 17 forks source link

ISSUE-1050 [PublicAsset] PublicAsset/set update JMAP method #1063

Closed vttranlina closed 1 month ago

vttranlina commented 1 month ago

resolve https://github.com/linagora/tmail-backend/issues/1050

vttranlina commented 1 month ago

I agree, now the update method looks like "reset identityId list", it is not easy when we want to add/remove one identityId

quantranhong1999 commented 1 month ago

What does the team think about adopting this?

+1

Arsnael commented 1 month ago

+1

Arsnael commented 1 month ago

Spec modification => https://github.com/linagora/tmail-backend/pull/1070#pullrequestreview-2080340783

It's ok to refactor the code here to do the full reset, and do partial upgrade in an other PR.

Might want to change /set create first though to fit the new identityIds representation

vttranlina commented 1 month ago

I updated code for new spec at commit: https://github.com/linagora/tmail-backend/pull/1063/commits/06125be43128a399ded6da2806bb2d82111e8738 (this pr)