search

linagora / tmail-backend

GNU Affero General Public License v3.0
30 stars 17 forks source link

ISSUE-1095 More @BasicFeature JMAP integration tests #1096

Closed vttranlina closed 3 weeks ago

vttranlina commented 3 weeks ago

resolve https://github.com/linagora/tmail-backend/issues/1095

vttranlina commented 3 weeks ago

+1 for TeamMailboxSmtpContract too IMO.

it did https://github.com/linagora/tmail-backend/blob/master/tmail-backend/integration-tests/smtp/distributed-smtp-integration-tests/src/test/java/com/linagora/tmail/james/DistributedTeamMailboxSmtpTest.java#L24

chibenwa commented 3 weeks ago

+1 overall.

Can we get build time before and after for information?

vttranlina commented 3 weeks ago

Can we get build time before and after for information?

Before: Team-mail :: Integration Tests :: JMAP :: Distributed SUCCESS [05:10 min] Using the result of pr: https://github.com/linagora/tmail-backend/pull/1092 Ci result: https://james-jenkins.lin-saas.com/blue/organizations/jenkins/Tmail%20build/detail/PR-1092/1/pipeline/

After: Team-mail :: Integration Tests :: JMAP :: Distributed SUCCESS [37:03 min] Using the result of this pr CI result: https://james-jenkins.lin-saas.com/blue/organizations/jenkins/Tmail%20build/detail/PR-1096/3/pipeline/

Note that both pr run in same CI runner: ci-james-06 The gap is ~ 30 minutes, it's quite longer than my local test (3 minutes for all BasicFeature tag) image

chibenwa commented 3 weeks ago

Please make sure we use reuse forks in maven settings...

vttranlina commented 3 weeks ago

After reuse forks: Team-mail :: Integration Tests :: JMAP :: Distributed SUCCESS [05:57 min] It looks good

vttranlina commented 3 weeks ago

squash fixup