search

linagora / tmail-backend

GNU Affero General Public License v3.0
30 stars 17 forks source link

ISSUE-1090 TeamMailboxMember/set JMAP method #1114

Open hungphan227 opened 2 days ago

vttranlina commented 1 day ago

Don't forget rebase master

chibenwa commented 1 day ago

image

I have just made some updates to remove nested if. I guess the code looks good enough and there is no need to apply above stuff.

If / else branching is not ok in scala / functional code when a functionnal/monad approach is proposed. Code could still be clearer.

vttranlina commented 11 hours ago

a bit my contribute https://github.com/linagora/tmail-backend/commit/ba54428e75f1aab055876181c0dae4183b9220ff I will pair with @hungphan227 about it