search

linagora / tmail-backend

GNU Affero General Public License v3.0
36 stars 17 forks source link

Change blob store module chooser #928

Closed chibenwa closed 6 months ago

chibenwa commented 6 months ago

We were always encrypting the blob even if we are not saving it because of single-save

Cc @vttranlina

Note: guice injection are fucked up, I ended up reverting and not doing it for CNB as it was non essential

Arsnael commented 6 months ago 
1) [Guice/MissingImplementation]: No implementation for BlobStoreDAO annotated with @Named("wrapped") was bound.
vttranlina commented 6 months ago

Read it, honestly, I do not understand this pr, I see the pr just changing the name of guice instance unencrypted -> wrapped

chibenwa commented 6 months ago

@Arsnael will explain you.

We should lookup for singleSave then encrypt. Not the reverse.

Arsnael commented 6 months ago

@chibenwa I'm sorry, joining @vttranlina side here, I'm not sure I fully get what's going on in this PR either

chibenwa commented 6 months ago

The PR changes are likely bullshit.

We should lookup for singleSave then encrypt. Not the reverse.

That's the important bit.

vttranlina commented 6 months ago

rework pr https://github.com/linagora/tmail-backend/pull/930