ISSUE-938 Move RabbitMQ event bus keys to Redis

linagora / tmail-backend

GNU Affero General Public License v3.0

36 stars 17 forks source link

ISSUE-938 Move RabbitMQ event bus keys to Redis #943

Closed quantranhong1999 closed 5 months ago

quantranhong1999 commented 5 months ago

with module chooser:

RabbitMQ
RabbitMQ + Redis

quantranhong1999 commented 5 months ago

I perf-tested on sandbox and it seems fine at least no error logs.

But it seems the registration never got unregistered for this TMail work (no redis-unregister metrics), while it was fine for the POC with James. I will need to investigate that...

quantranhong1999 commented 5 months ago

But it seems the registration never got unregistered for this TMail work (no redis-unregister metrics), while it was fine for the POC with James. I will need to investigate that...

Well. Because TMail depends on James SHA1 it does not include this fix yet: https://github.com/apache/james-project/commit/02e74a57f07d50ca21349983db631f92da401769

Should be fine once TMail upgrades James SHA1.

quantranhong1999 commented 5 months ago

Please re-bench quickly this work to ensure this is on par with your previous tests.

The performance is still good. No related error logs.

Arsnael commented 5 months ago

Can you rebase and cleanup @quantranhong1999 ?