Closed quantranhong1999 closed 1 month ago
Idem for PushSubscriptions / james push? (& JIRA ticket?)
James side: https://github.com/apache/james-project/pull/2343
for postgres-app and FCM (on the TMail side) adoption: it could be done later as I introduced breaking change in the API so we would not forget to adapt.
Little james sha-1 upgrade on tmail-backend perhaps? :)
Little james sha-1 upgrade on tmail-backend perhaps? :)
Why
GIVEN at first TMail support a change type e.g. Thread, and user register updates for the Thread changes via
FirebaseSubscription/set
. WHEN TMail gives up supporting the Thread change type THEN:FirebaseSubscription/get
likely would fail asTypeStateFactory
fails to parse the Thread type from DBFirebasePushListener
likely would fail asTypeStateFactory
fails to parse the Thread type from DBExpect: Should not fail if DB contains the "no longer existing types".
How
Be more lenient in
TypeStateFactory
: skip the parsing failure upon retrieval phase and a WARN level log cf: https://github.com/linagora/tmail-backend/pull/956#discussion_r1515814867Notes
Could contribute this to PushSubscription on James side if suitable...