search

linagora / tmail-backend

GNU Affero General Public License v3.0
36 stars 17 forks source link

NO_REVIEW - ISSUE-950 [ICS Reply] CalendarEvent/accept JMAP method #963

Closed vttranlina closed 5 months ago

vttranlina commented 5 months ago

The clone of https://github.com/linagora/tmail-backend/pull/960 It looks like we have a CRLF/LF issue (ics file)

Arsnael commented 5 months ago

Honestly I continued having that CRLF/LF issue.

At the end, i recreated the file (by doing a copy of meeting.ics and then reapply your changes) and it coutns it as a difference of a CRLF/LF att he beginning of the file.

=> https://github.com/linagora/tmail-backend/pull/965/commits/aba57c25d97f9a9e7942ee7131f6fbf7b8edcdd9

Mind if you committed with the IDE, it tried to make me change back that, which I said no. Maybe problem here?

chibenwa commented 5 months ago

Git commit do not preserve CRLF

You need to temporarily alter your git config to do so.

Also cat -A xxxxx shows the line ending.

vttranlina commented 5 months ago

thank guys <3