search

linagora / tmail-backend

GNU Affero General Public License v3.0
31 stars 17 forks source link

Update James SHA-1 (pg-app) #978

Closed Arsnael closed 3 months ago

Arsnael commented 3 months ago

Rebase on james/postgresql branch for tmail pg app

vttranlina commented 3 months ago

CI failed:

webSocketShouldPushNewMessageWhenChangeSubscriptionOfMailbox(GuiceJamesServer) – com.linagora.tmail.james.MemoryMailboxSetMethodTest

Expecting actual:
  "{"@type":"Response","requestId":"req-36","sessionState":"2c9f1b12-b35a-43e6-9af2-0106fb53a943","methodResponses":[["Mailbox/set",{"accountId":"29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6","oldState":"770d5c82-9649-4708-bdf2-4f9f27925a6f","updated":{"1":{}},"newState":"ca21a801-c929-40fc-91e9-4660bbe6cf9a"},"c1"]]}"
to start with:
  "{"@type":"StateChange","changed":{"29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6":{"Mailbox":"

It looks like related to commit: https://github.com/apache/james-project/pull/2108/files#diff-ac1365541e08f69dc4e57ee445faa58e904eb86a908f3b76c359ace9b0aa376f

image

Arsnael commented 3 months ago

Yes it is, was looking into it :) Escaped me...

@hungphan227 can you explain me again why that change initially? Did you check it was not affecting other tests than postgres?

hungphan227 commented 3 months ago

Yes it is, was looking into it :) Escaped me...

@hungphan227 can you explain me again why that change initially? Did you check it was not affecting other tests than postgres?

Oh sorry I have not checked MemoryMailboxSetMethodTest

The right answer should be in the first ws.receive() or the second ws.receive()

Arsnael commented 3 months ago

Why does it comes second for postgres and not other implems though? :)

Arsnael commented 3 months ago

Disabling that test temporarily for now. That should be fixed on base James.

Arsnael commented 3 months ago

=> https://github.com/linagora/james-project/issues/5133