linagora / twake-on-matrix

A multi-platform (Flutter) application for connecting to Matrix - an open network for secure, decentralized communication, with your favorite devices.
GNU Affero General Public License v3.0
26 stars 7 forks source link

TW-1584: Sent files in room #1706

Closed Te-Z closed 2 weeks ago

Te-Z commented 3 weeks ago

Ticket:

https://github.com/linagora/twake-on-matrix/issues/1584

Edit: For sync between file tab and chat download, we didn't found the perfect solution but if a download is in progress for example starting from file tab, when clicking on file in chat screen it will display the right download status.

Demo:

Web

Capture vidéo du 22-04-2024 15:29:30.webm

Mobile (android):

https://github.com/linagora/twake-on-matrix/assets/31937920/9917b453-86ea-47b3-9550-c084f557de08

github-actions[bot] commented 3 weeks ago

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1706

hoangdat commented 3 weeks ago

please apply the same style with design

image
hoangdat commented 3 weeks ago

please demo for the case of encrypted room also

sherlockvn commented 3 weeks ago

im testing ios for you @Te-Z

sherlockvn commented 3 weeks ago

https://github.com/linagora/twake-on-matrix/assets/43041967/114107d3-9a0a-4e8c-89f0-5c159196a5f6

sherlockvn commented 3 weeks ago

You can test the styles of file in ios in web responsive mode

Te-Z commented 3 weeks ago

RPReplay_Final1713338782.MP4

  • [ ] style in IOS is not correct
  • [x] Show download icon when file is not downloaded
  • [ ] open file in ios is freeze ?
  • [ ] Nice to have, files in divided for each month like design

Ticket created to debug iOS: https://github.com/orgs/linagora/projects/6/views/1?pane=issue&itemId=60332401

hoangdat commented 3 weeks ago

IMO, we should keep the height of file tile consistent: in downloading or in normal. Avoid height is changing

https://github.com/linagora/twake-on-matrix/assets/6462404/f1dce5ad-522c-46ee-922d-0d2eb340e90c

nqhhdev commented 3 weeks ago
Screenshot 2024-04-22 at 09 04 00
nqhhdev commented 3 weeks ago

IMO: should you take a look at this ticket after finished current ticket

https://github.com/linagora/twake-on-matrix/issues/1715

sherlockvn commented 3 weeks ago

What about show in chat feature ?

sherlockvn commented 3 weeks ago

What about show in chat feature ?

Create another ticket: https://github.com/linagora/twake-on-matrix/issues/1718

sherlockvn commented 3 weeks ago

Tested on web:

https://github.com/linagora/twake-on-matrix/assets/43041967/1dd625c7-c6ec-4f07-85d6-e6d9482dea8e

sherlockvn commented 2 weeks ago

Hey, because of this ticket block some other tickets, if you can fix it quick please prioritize this one first, if not you can rebase and do part II after this ticket.

Te-Z commented 2 weeks ago

Hey, because of this ticket block some other tickets, if you can fix it quick please prioritize this one first, if not you can rebase and do part II after this ticket.

Hi @sherlockvn I didn't found any quick solution to synchronize the download status from files tab to chat screen, but it works when downloading on chat screen and going on files tab. I will do it in an other ticket so this one won't block others

hoangdat commented 2 weeks ago

IMO, please keep file size also after downloading

image
hoangdat commented 2 weeks ago

overall, LGTM

Te-Z commented 2 weeks ago

IMO, please keep file size also after downloading

image

done @hoangdat Capture d’écran du 2024-04-25 08-07-16

hoangdat commented 2 weeks ago

hi, please rebase @Te-Z