linagora / twake-on-matrix

A multi-platform (Flutter) application for connecting to Matrix - an open network for secure, decentralized communication, with your favorite devices.

GNU Affero General Public License v3.0

64 stars 18 forks source link

TW-1812 Remove X from the search bar when it's empty #1852

Closed KhaledNjim closed 5 months ago

KhaledNjim commented 5 months ago

Issue :

1812

Solution:

wrapped the suffixIcon in ValueListenableBuilder to determine if the icon should be displayed or not

demo mobile :

chat1.webm

demo web :

https://github.com/linagora/twake-on-matrix/assets/160496984/fc9458a7-c848-469d-a888-82c01ab08e7b

github-actions[bot] commented 5 months ago

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1852

nqhhdev commented 5 months ago

Pls add demo on web also

nqhhdev commented 5 months ago

Just tested this PR on my localhost and simulator. Works well, however I have some question about coding style pls check it.

nqhhdev commented 5 months ago

pls rebase

KhaledNjim commented 5 months ago

pls rebase

done

Te-Z commented 5 months ago

@KhaledNjim please squash. LGTM ;)