TW-1916: Improve search exact Matrix ID inside Contact tab - Githubissues

linagora / twake-on-matrix

A multi-platform (Flutter) application for connecting to Matrix - an open network for secure, decentralized communication, with your favorite devices.

GNU Affero General Public License v3.0

64 stars 18 forks source link

TW-1916: Improve search exact Matrix ID inside Contact tab #1930

Closed hieutbui closed 4 months ago

hieutbui commented 4 months ago

Ticket

1916

Root cause

Right now, when search for exact Matrix ID, it will return contacts as an External contact.
Right now, we use Contact widget for rendering recent contact. However, Contact widget will only fetch profile information if status is active. Because recent contact don't have status value, cannot fetch avatar.

Solution

Only return External contact if search for contact return empty and keyword is a Matrix ID
Use RecentItemWidget instead.

Pre-merge

Need merge: #1911
Change base branch to main

Resolved

Web:

https://github.com/linagora/twake-on-matrix/assets/80142234/c1b81e02-cb79-44a2-b753-ffa2da4f25f7

Android:

https://github.com/linagora/twake-on-matrix/assets/80142234/f5f28600-684b-48d6-8cbf-37465335b02c

IOS:

github-actions[bot] commented 4 months ago

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1930

nqhhdev commented 4 months ago

Pls rebase it, and update your PR again. After I'll test it