linagora / twake-on-matrix

A multi-platform (Flutter) application for connecting to Matrix - an open network for secure, decentralized communication, with your favorite devices.
GNU Affero General Public License v3.0
64 stars 18 forks source link

TW-1902 update chat list item ui (Part 2) #1949

Closed KhaledNjim closed 2 months ago

KhaledNjim commented 4 months ago

Ticket

https://github.com/linagora/twake-on-matrix/issues/1902

Figma

Impact description

chat list items design updated

Test recommendations

test on all supported platforms with different sized screens

Resolved

-Web: image

https://github.com/user-attachments/assets/b09910bf-b906-4cbe-8f64-94232c80f9d2

image

github-actions[bot] commented 4 months ago

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1949

sherlockvn commented 4 months ago

For preview image in chat list latest message, you have to create a function like the function calcLocalizedBody and modify it in the file chat_list_item_subtitle.dart because the function calcLocalizedBody is used in many places. the thumbnail of image and its information you can easily created from MxcImage. and be careful because it has many kind of events in matrix.

sherlockvn commented 4 months ago

If you want a pair. please ping me

Te-Z commented 4 months ago

We should have the @ icon when the user is tagged in a room

image

Te-Z commented 4 months ago

I think there's too much space between items compared to the design (screenshot from web, but please check on mobile also)

image

sherlockvn commented 3 months ago

it works well in iOS device, one small thing, can you make the splash full item or at least make it center ? it looks better IMO

https://github.com/user-attachments/assets/cce1d3d8-fa55-4f0a-8fd3-856aeca82d0e

sherlockvn commented 3 months ago

it works well in iOS device, one small thing, can you make the splash full item or at least make it center ? it looks better IMO

RPReplay_Final1724405603.MP4

@KhaledNjim, can you do this one, also video preview the design has been updated, you can do it in the part III i think

https://www.figma.com/design/uLw3iWnOEGaRlJnfPz4Pv0/Twake-%5BMatrix%5D?node-id=27307-2606&t=dkheZEAJVIB3yuyz-4

sherlockvn commented 3 months ago

i run it in my device, but the avatar is not synchronized IMG_C1DBB91CFB54-1

KhaledNjim commented 3 months ago

i run it in my device, but the avatar is not synchronized IMG_C1DBB91CFB54-1

i cant reproduce this can you provide more infos

sherlockvn commented 3 months ago

i run it in my device, but the avatar is not synchronized IMG_C1DBB91CFB54-1

i cant reproduce this can you provide more infos

i have multiple accounts, and when i terminated my app, reopen it again, you will see

https://github.com/user-attachments/assets/7b65d704-2c18-4196-ad9a-7af65c7cb1e8

KhaledNjim commented 3 months ago

it works well in iOS device, one small thing, can you make the splash full item or at least make it center ? it looks better IMO

RPReplay_Final1724405603.MP4

splashFix.webm

KhaledNjim commented 3 months ago

it works well in iOS device, one small thing, can you make the splash full item or at least make it center ? it looks better IMO RPReplay_Final1724405603.MP4

@KhaledNjim, can you do this one, also video preview the design has been updated, you can do it in the part III i think

https://www.figma.com/design/uLw3iWnOEGaRlJnfPz4Pv0/Twake-%5BMatrix%5D?node-id=27307-2606&t=dkheZEAJVIB3yuyz-4

i added video preview

hoangdat commented 2 months ago
KhaledNjim commented 2 months ago
  • [x] after app terminated, account's avatar in the bottom bar is wrong

Fixed

bottomAvatarSync.webm

nqhhdev commented 2 months ago

Design:

Screenshot 2024-09-13 at 17 29 46

Your code:

Simulator Screenshot - iPhone 15 - 2024-09-13 at 17 26 17

hoangdat commented 2 months ago
KhaledNjim commented 2 months ago
  • [ ] please show me screenshot in Chat screen

mobile

image

Web

image

KhaledNjim commented 2 months ago

Design:

Screenshot 2024-09-13 at 17 29 46

Your code:

Simulator Screenshot - iPhone 15 - 2024-09-13 at 17 26 17

  • padding only 8px for weight and height

In the example, the item is centered because it only has two lines. For long messages or group chats, it has 8px padding.

Design

image

Code

image

nqhhdev commented 2 months ago

In the example, the item is centered because it only has two lines. For long messages or group chats, it has 8px padding.

Hi @KhaledNjim, The padding is huge, think about it. Can you align it to the Avatar?

nqhhdev commented 2 months ago

One more: In main branch updated flutter version is 3.24.0 so pls update your branch

nqhhdev commented 2 months ago

When I'm using to hover in chat list item, UI/UX is pretty bad because of the huge white space!

https://github.com/user-attachments/assets/05f33148-c3cd-4c1a-a681-9b4ea203dcef

nqhhdev commented 2 months ago

Pls check hover and padding on web

Screenshot 2024-09-16 at 10 35 59

Design

Screenshot 2024-09-16 at 10 36 57
nqhhdev commented 2 months ago
Screenshot 2024-09-16 at 10 38 08

Design

Screenshot 2024-09-16 at 10 36 57
nqhhdev commented 2 months ago

Pls check it

Screenshot 2024-09-16 at 10 41 30
nqhhdev commented 2 months ago
hoangdat commented 2 months ago

WEB

image
hoangdat commented 2 months ago