TW-1923: Improve search screen - Githubissues

linagora / twake-on-matrix

A multi-platform (Flutter) application for connecting to Matrix - an open network for secure, decentralized communication, with your favorite devices.

GNU Affero General Public License v3.0

64 stars 18 forks source link

TW-1923: Improve search screen #1961

Open hieutbui opened 4 months ago

hieutbui commented 4 months ago

Ticket

1923

Root cause

Currently, when search message is empty, search controller doesn't check for keyword is Matrix ID

Solution

When search message is empty, check if keyword is Matrix ID then hide empty widget.

Test recommendations

Search keywords that is a valid Matrix ID
Search keywords that is a valid Matrix ID but not complete (Ex: @test:domain.co)
Send message with a Matrix ID inside a room then search for this Matrix ID

Resolved

Web:

https://github.com/user-attachments/assets/5a4374c7-98c8-4295-9d6a-0f6c324d6c61

Android:
IOS:

github-actions[bot] commented 4 months ago

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1961

sherlockvn commented 4 months ago

not in the DOD, but i think this case, we should remove the Messages section too

KhaledNjim commented 3 months ago

not in the DOD, but i think this case, we should remove the Messages section too

Updated

nqhhdev commented 1 day ago

I rebased and tested it on mobile, web works well

nqhhdev commented 1 day ago

I have one concern about padding in chat search on web. WDYT @hoangdat @KhaledNjim

Currently

Screenshot 2024-11-25 at 10 23 57

After updated

Screenshot 2024-11-25 at 10 22 32